Skip to content

fix: treat log files as plaintext#8599

Closed
SSDWGG wants to merge 2 commits into
nextcloud:mainfrom
SSDWGG:fix/log-files-plaintext
Closed

fix: treat log files as plaintext#8599
SSDWGG wants to merge 2 commits into
nextcloud:mainfrom
SSDWGG:fix/log-files-plaintext

Conversation

@SSDWGG
Copy link
Copy Markdown
Contributor

@SSDWGG SSDWGG commented May 16, 2026

Summary

  • map .log files to plaintext highlighting
  • add a regression test for the extension mapping

Fixes #5253

Tests

  • npx vitest run src/tests/helpers/mappings.spec.ts

@mejo-
Copy link
Copy Markdown
Member

mejo- commented May 18, 2026

@SSDWGG thanks as well for this contribution. As far as I can see, Text doesn't open .log files at all per default. So I wonder whether it's useful to add syntax highlighting conditions for it. Can you explain your usecase a bit?

Regarding the unit test, I think it can be dropped in any case. It doesn't test much except that the object key you introduced to mappings.ts has the value your put there.

@mejo- mejo- added enhancement New feature or request needs info labels May 18, 2026
@SSDWGG SSDWGG closed this by deleting the head repository May 29, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Color markings for .log files, not for .txt files

2 participants